Skip to content

Fix creating bridged network interface in limactl #3813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025

Conversation

dharsanb
Copy link
Contributor

@dharsanb dharsanb commented Aug 9, 2025

Fixes: #3782

@dharsanb dharsanb force-pushed the master branch 2 times, most recently from 73c0545 to c840a71 Compare August 9, 2025 12:03
@dharsanb
Copy link
Contributor Author

dharsanb commented Aug 9, 2025

Can I get some help here please.
Thanks.

Copy link
Member

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why you change code not related to bridged mode. The best way to fix this is to add a failing test and then add a minimal fix for the bridged case.

Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, but please squash commits.

@dharsanb
Copy link
Contributor Author

Change looks good to me, but please squash commits.

Done.

Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois added this to the v2.0.0 milestone Aug 11, 2025
@jandubois jandubois merged commit 93ef4ce into lima-vm:master Aug 11, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a new bridged network results in an error.
3 participants